Add some dark theme tweaks and small html fix #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
e8353f5 was added because I noticed that if you have a font size (possible now that we have themes) other than the default 12px, the overlay for the sample match doesn't line up properly. I suppose this fix might not be satisfactory, it fixes the sample text to be always 12px regardless of theme setting, it seemed easier than doing math to figure out how many pixels wide each of the various font sizes are before rendering the overlay. Your call ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peterflynn I am not sure if I chose colors that suit you, but I did make it so that the matches and matched groups show up ok on a dark theme.
When I was looking at the styles I noticed that the resulting HTML when you did
.showoninline-regex-groupsended with an orphanedstyle>so I just added.css()to explicitly change the style todisplay: inlineto avoid the orphaned tag. Not a big deal since it worked fine before ;)Great extension, btw!